a c++ question - 未名空间MITBBS历史存档

国际科技财经博客移民网络热点娱乐民生时事公众号

Redian新闻

>未名空间

>Programming - 葵花宝典

a c++ question

a c++ question# Programming - 葵花宝典

t*i2007-11-17 08:11

1 楼

Class pointer {
....
...
}
Class screen {
...
..
pointer* mp;
}
function()
{
screen* ps = new screen();
screen ps2= *ps;
....
...
delete ps;
}
when function run, the program will crash. Give the reason.

f*w2007-11-17 08:11

2 楼

I did not see anything wrong here. Any hint?

t*i2007-11-17 08:11

3 楼

I don't know either. This is a question I were asked during a interview.

【在 f**********w 的大作中提到】

: I did not see anything wrong here. Any hint?

k*n2007-11-17 08:11

4 楼

write the code by yourself and see if it crashes.

【在 t*i 的大作中提到】

: I don't know either. This is a question I were asked during a interview.

b*n2007-11-17 08:11

5 楼

screen的copy ctor怎么定义的，如果没有copy ps指向的内容，就有问题了呗。

【在 t*i 的大作中提到】

: Class pointer {
: ....
: ...
: }
: Class screen {
: ...
: ..
: pointer* mp;
: }
: function()

f*w2007-11-17 08:11

6 楼

Based on the original code provided by OP, it wont crash.
But once the mp pointer was pointed to an actual instance of pointer class ,
that will cause problem. Anyway, it is not a good practice.

S*t2007-11-17 08:11

7 楼

shallow copy?

【在 t*i 的大作中提到】

: Class pointer {
: ....
: ...
: }
: Class screen {
: ...
: ..
: pointer* mp;
: }
: function()

t*u2007-11-17 08:11

8 楼

you need to implement copy-ctor for class screen.

【在 t*i 的大作中提到】

: Class pointer {
: ....
: ...
: }
: Class screen {
: ...
: ..
: pointer* mp;
: }
: function()

t*i2007-11-17 08:11

9 楼

感谢各位的解答，我当时也猜是copy constructor的问题，但是想不明白为啥会crash.

【在 t****u 的大作中提到】

: you need to implement copy-ctor for class screen.

t*u2007-11-17 08:11

10 楼

if you don't have copy-ctor, it just does a member wise copy,
so mp ps->mp will be duplicated to ps2.mp.
your "delete ps", will be supposed to delete the mp in your screen class'
dtor, (otherwise, you will have memory leak). When the function ends, ps2's
dtor will get called. It will try to delete ps2.mp (the same pointer as ps->
mp which is already deleted in ps's dtor), then crash.

crash.

【在 t*i 的大作中提到】

: 感谢各位的解答，我当时也猜是copy constructor的问题，但是想不明白为啥会crash.

j*i2007-11-17 08:11

11 楼

google 深拷贝浅拷贝

crash.

【在 t*i 的大作中提到】

: 感谢各位的解答，我当时也猜是copy constructor的问题，但是想不明白为啥会crash.

c*x2007-11-17 08:11

12 楼

test.

c*x2007-11-17 08:11

13 楼

the reason is you have an unintialized pointer : pointer* mp;
mp is not null.

c*x2007-11-17 08:11

14 楼

int *a = new int(2);
delete a;
delete a;
the delete *a twice is OK.

c*x2007-11-17 08:11

15 楼

test.
pointer {
....
...
}
Class screen {
...
..
pointer* mp=null; // }
function()
{
screen* ps = new screen();
screen ps2= *ps;
....
...
delete ps;
}

e*w2007-11-17 08:11

16 楼

this is a typical source for crashing..

【在 c********x 的大作中提到】

: int *a = new int(2);
: delete a;
: delete a;
: the delete *a twice is OK.

r*r2007-11-17 08:11

17 楼

你确信？

【在 c********x 的大作中提到】

: int *a = new int(2);
: delete a;
: delete a;
: the delete *a twice is OK.

c*x2007-11-17 08:11

18 楼

pretty sure.

【在 r****r 的大作中提到】

: 你确信？

p*x2007-11-17 08:11

19 楼

good point.

s
->

【在 t****u 的大作中提到】

: if you don't have copy-ctor, it just does a member wise copy,
: so mp ps->mp will be duplicated to ps2.mp.
: your "delete ps", will be supposed to delete the mp in your screen class'
: dtor, (otherwise, you will have memory leak). When the function ends, ps2's
: dtor will get called. It will try to delete ps2.mp (the same pointer as ps->
: mp which is already deleted in ps's dtor), then crash.
:
: crash.

z*e2007-11-17 08:11

20 楼

no, at least doesn't work for visual c++, tested.

【在 c********x 的大作中提到】

:
: pretty sure.

W*g2007-11-17 08:11

21 楼

dangling pointer.

h*e2007-11-17 08:11

22 楼

请你不要玷污Caltech的名誉好不好。

【在 c********x 的大作中提到】

: test.
: pointer {
: ....
: ...
: }
: Class screen {
: ...
: ..
: pointer* mp=null; // : }